Add inline documentation for Type and DataType. #24561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
docs
JeffBezanson
reviewed
Apr 4, 2018
|
I think this would be nice to get in. @phrb, if you are up for it, can you rebase to master and trim the PR examples to make it concise? |
|
The failures need investigating... |
|
Sorry I had a whitespace bug committed. Can you rebase on master? There are some other issues that need to be addressed too. |
phrb
force-pushed
the
inline-type-docs
branch
2 times, most recently
from
9fa4f52 to
16a8f39
Compare
|
@ViralBShah, I've rebased, trimmed examples, and corrected type annotations. |
Co-authored-by: Matt Bauman <[email protected]>
mbauman
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23655.