random: remove useless @inline #23903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did more or less what was suggested here for files in "random/", i.e. remove
@inlineannotations and check if performance is degraded. According to "BaseBenchmarks/src/random", there are two regressions:randn, for which I guess it's too critical, so I re-added@inline(EDIT: not anymore on master, see post below)randstring: by maybe about 30%. It was not obvious which set of@inlineare contributing to the regression, but I would believe that it's not a time critical function, so that it would be OK.I didn't run the whole BaseBenchmarks suite locally, so will run it here to check for other possible regressions: @nanosoldier
runbenchmarks(ALL, vs=":master")