Add a test for #22582/#22022. #23021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
backport pending 0.6
test
tkelman
reviewed
Jul 29, 2017
test/codegen.jl
Outdated
| function issue22582!(a::AbstractArray, b) | ||
| len = length(a) | ||
| if b | ||
| ccall(:jl_array_grow_end, Void, (Any, UInt64), a, 1) |
Contributor
There was a problem hiding this comment.
is this the right signature even on 32 bit?
Member
Author
There was a problem hiding this comment.
Good call, copied it blindly, should be Csize_t.
Member
Author
|
Failure is unrelated ( |
ararslan
pushed a commit
that referenced
this pull request
Sep 13, 2017
vtjnash
pushed a commit
that referenced
this pull request
Sep 14, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 15, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 16, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other part of #22022 (SROA + addrspace) is harder to test in plain Julia, but I've added a test in CUDAnative.