Skip to content

Conversation

@Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Apr 26, 2017

Ref. #20114. Rerunning grep -Er '\bArray\{[^,]+\}\([0-9]+\)' base after #21533 and #21501 revealed a few straggling Array{...}(...)s that should be Vector{...}(...)s. This pull request clears those stragglers (and a few instances that the preceding grep doesn't catch.) Best!

@ararslan ararslan added the arrays [a, r, r, a, y, s] label Apr 26, 2017
@alyst
Copy link
Contributor

alyst commented Apr 26, 2017

In lapack.jl there are a few cases that this grep doesn't catch because the length is not an integer constant. E.g. there is some magic at L1317:

work = Array{$elty}(lwork)
rwork = Array{$relty}(BlasInt(rwork[1]))
iwork = Array{BlasInt}(iwork[1])

Actually, should resize!() be used in such cases? (Probably requires a separate PR)

Same for L1224

@andreasnoack
Copy link
Member

Actually, should resize!() be used in such cases? (Probably requires a separate PR)

Yes and yes

@Sacha0
Copy link
Member Author

Sacha0 commented Apr 26, 2017

In lapack.jl there are a few cases that this grep doesn't catch because the length is not an integer constant.

Indeed :). I have work inbound for more general search patterns. Best!

@Sacha0 Sacha0 merged commit d11e233 into JuliaLang:master Apr 27, 2017
@Sacha0 Sacha0 deleted the nixarray branch April 27, 2017 15:57
@Sacha0
Copy link
Member Author

Sacha0 commented Apr 27, 2017

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrays [a, r, r, a, y, s]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants