fix some specificity and intersection issues #20665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
Sacha0
reviewed
Feb 18, 2017
| args_morespecific(a, b) = ccall(:jl_type_morespecific, Cint, (Any,Any), a, b) != 0 | ||
| let | ||
| a = Tuple{Type{T1}, T1} where T1<:Integer | ||
| a = Tuple{Type{T1}, T1} where T1<:Integer |
There was a problem hiding this comment.
Additional space intentional? (For alignment?) And likewise below?
There was a problem hiding this comment.
Yes, aligning the types makes the test case much easier to read.
Sacha0
reviewed
Feb 18, 2017
| # (2) map[!] entry points | ||
| map{Tf}(f::Tf, A::SparseVecOrMat) = _noshapecheck_map(f, A) | ||
| map{Tf}(f::Tf, A::SparseVector) = _noshapecheck_map(f, A) | ||
| map{Tf}(f::Tf, A::SparseMatrixCSC) = _noshapecheck_map(f, A) |
There was a problem hiding this comment.
Did these (and the similar broadcast) methods cause an ambiguity or so?
There was a problem hiding this comment.
Yes this change makes ambiguity detection pickier again.
This definition of map was less specific in the type of A, but more specific in argument count compared to the next one.
There was a problem hiding this comment.
Cheers, thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This began as an attempt to fix the dispatch issue identified here: JuliaData/IndexedTables.jl#30 (comment)
Fixing that case led to a chain of related bugs, all of which needed to be fixed to get both that case and the rest of the tests passing. This entailed a minor overhaul of the specificity code, fixing a couple todo items and making the logic clearer overall. In particular we should now have the property that at most one of
more_specific(a,b)andmore_specific(b,a)can be true, which makes it much easier to reason about the code and was not always true before.