Fix doctests in docstrings #19562
Merged
Fix doctests in docstrings #19562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses two space indent rather than a tab to match the indent used by sparse vector printing.
Notable changes:
* sparse matrix printing indent changed to match that
of sparse vectors, namely two space indent not single tab;
* removal of `...` after many backtraces which weren't needed;
* removal of `<BLANKLINE>` since we just use a blankline instead;
* fix bad indentation of some doctests, which were causing them
not to be run;
* update line numbers in some backtraces;
* use named doctests for `splice!` to share state between two tests.
This only fixes doctests in `base`, not in `doc/src`.
tkelman
approved these changes
Dec 12, 2016
Member
|
Tests passed; @tkelman approved; it doesn't get better than that. Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
...after many backtraces which weren't needed;<BLANKLINE>since we just use a blankline instead;splice!to share state between two tests.This only fixes doctests in
base, not indoc/src. I'll put the changes todoc/srcin another PR once this one is done.