ulimit the max open pipes during testing #19307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/pipe-ulimit
branch
from
c3ad541 to
2984956
Compare
Member
|
Looks like this doesn't fix the spawn testset issue on Travis? |
Contributor
|
travis doesn't run the tests via the makefile |
vtjnash
force-pushed
the
jn/pipe-ulimit
branch
2 times, most recently
from
689fd78 to
97e8713
Compare
and add error-handling and tests to Base._fd
vtjnash
force-pushed
the
jn/pipe-ulimit
branch
from
97e8713 to
adaad62
Compare
Member
Author
|
@tkelman looks like this is going to pass all the tests. merge when it does? Appveyor link, since it seems to be missing from the PR, is https://ci.appveyor.com/project/JuliaLang/julia/build/1.0.7908 |
Member
|
The tests are passing on Linux, but the OS X build stalled while upgrading Homebrew. However, the |
Contributor
|
can this be done in runtests.jl or test/spawn.jl? this will still fail Base.runtests("spawn") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19132
it seems that travis may suddenly have changed the default ulimit here, so the test is now failing on their default configuration