add lexproduct, lexicographic-order product iterator
#18825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Oct 7, 2016
| ```jldoctest | ||
| julia> collect(product(1:2,3:5)) | ||
| julia> vec(collect(product(1:2,3:5))) |
Contributor
There was a problem hiding this comment.
run make docs and commit the result
Contributor
There was a problem hiding this comment.
Or if this isn't exported and not in the manual, then we should document them with qualified names if we want users to know about them. Time for an IterTools module within base?
Member
Author
There was a problem hiding this comment.
Ok, I'll do that. I'll go with IterTools and see what people think.
This removes a spurious warning if Base.X is deprecated to Mod.X, and one does `using Mod`. `X` is available from both `Base` and `Mod`, but we asked for the non-deprecated one so there should be no warning.
JeffBezanson
force-pushed
the
jb/lexproduct
branch
from
1f14026 to
14fe9ce
Compare
Contributor
|
I assume this is something you're planning on using for some other feature, which is why it needs to be here rather than Iterators.jl? |
Member
Author
|
Not necessarily, they just seem to go together. It also reuses some internal types and functions in Base defined for |
JeffBezanson
force-pushed
the
jb/itertools
branch
4 times, most recently
from
7ade52d to
7cc22c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.