Skip to content

Conversation

@timholy
Copy link
Member

@timholy timholy commented Aug 11, 2016

It turns out we were returning a Vector{Int} for operations that should return a Range

It turns out we were returning a Vector{Int} for operations that should return a Range
@tkelman
Copy link
Contributor

tkelman commented Aug 12, 2016

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@timholy
Copy link
Member Author

timholy commented Aug 13, 2016

I've tested those regressions; 2/3 are clearly noise (and in fact go the opposite way in my hands). The simd benchmark appeared to have a 12% regression when I tested, but looking at the code I don't think this is related.

@timholy timholy merged commit e8ddc42 into master Aug 13, 2016
@timholy timholy deleted the teh/oneto_indexing branch August 13, 2016 11:04
tkelman pushed a commit that referenced this pull request Aug 20, 2016
It turns out we were returning a Vector{Int} for operations that should return a Range

(cherry picked from commit 3bb7815)
ref #17980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants