Minor ASAN improvements #17731
Merged
Minor ASAN improvements #17731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sigstack size change is covered by #17727 |
src/julia_internal.h
Outdated
| #endif | ||
|
|
||
| #ifndef __has_feature | ||
| #define __has_feature(x) 0 |
Contributor
There was a problem hiding this comment.
defining this might change other code's behavior
Member
Author
There was a problem hiding this comment.
I got this from the Clang documentation on this extension
maleadt
force-pushed
the
tb/asan
branch
2 times, most recently
from
72aac3e to
beaf0a4
Compare
Member
Author
|
Updated: removed the signal stack size change and removed the definition of |
SIGSEGV can be benign, but ASAN will die so we need to be able to handle the signal ourselves (see #17706).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JL_ASAN_ENABLEDoption for all conditional code