Skip to content

close #8269: grow arrays incrementally by factors of 1.5 rather than 2 #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

close #8269: grow arrays incrementally by factors of 1.5 rather than 2 #16305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,11 +897,12 @@ STATIC_INLINE void jl_array_grow_at_end(jl_array_t *a, size_t idx,
if (__unlikely(reqmaxsize > a->maxsize)) {
size_t nb1 = idx * elsz;
size_t nbinc = inc * elsz;
// if the requested size is more than 2x current maxsize, grow exactly
// otherwise double the maxsize
size_t newmaxsize = reqmaxsize >= a->maxsize * 2
// if the requested size is more than 1.5x current maxsize, grow exactly
// otherwise use 1.5x the maxsize
size_t growmaxsize = (a->maxsize*3)>>1;
size_t newmaxsize = reqmaxsize >= growmaxsize
? (reqmaxsize < 4 ? 4 : reqmaxsize)
: a->maxsize * 2;
: growmaxsize;
newmaxsize = limit_overallocation(a, n, newmaxsize, inc);
size_t oldmaxsize = a->maxsize;
int newbuf = array_resize_buffer(a, newmaxsize);
Expand Down