matmul: don't assume the existence of type-conversions #14618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 709c867)
Contributor
|
okay, may as well also put the conflict-resolved cherry pick of #14372 in here too |
(cherry picked from commit 2c53437)
Member
Author
|
Done. |
Contributor
|
travis failure was a caching hiccup, pr's against non master or release confuse the caching a bit. merging so travis and appveyor run on it in the other pr. |
tkelman
added a commit
that referenced
this pull request
Jan 9, 2016
matmul: don't assume the existence of type-conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 709c867)
This is a backport of #14293 that doesn't rely on #13803. It loses the ability to do
A*B, but it works withA_mul_B!(C, A, B). CC @tkelman, note this is against your tk/backports-0.4.3 branch.In retrospect, in the tests I realize I should have (for mathematical obviousness) named
RootIntsomething likePureImaginary, as a more familiar example of a type of number where!isa(::T * ::T, ::T)and for which the conversion toTcannot be defined.