Skip to content

Conversation

@tkelman
Copy link
Contributor

@tkelman tkelman commented Dec 5, 2015

introduced by cb52f15
jl_ios_get_nbyte_int does not support int128 right now

introduced by cb52f15
jl_ios_get_nbyte_int does not support int128 right now
@tkelman
Copy link
Contributor Author

tkelman commented Dec 5, 2015

backport for second (and third) commit, if enabling assertions works on appveyor

@JeffBezanson
Copy link
Member

I'm about to push a test for this that doesn't rely on assertions.

@JeffBezanson
Copy link
Member

Here it is, in case you want to add it here:

# make sure reading 128-bit ints from RandomDevice works
let a = [rand(RandomDevice(), UInt128) for i=1:10]
    @test reduce(|, a)>>>64 != 0
end

I'll hold off on pushing.

@tkelman
Copy link
Contributor Author

tkelman commented Dec 6, 2015

thanks, pushed that here. looks green on the travis linux branch build. merge if green everywhere else?

tkelman added a commit that referenced this pull request Dec 6, 2015
hopefully fix assertion failure in random test
@tkelman tkelman merged commit 397a795 into master Dec 6, 2015
@tkelman tkelman deleted the tk/int128assert branch December 6, 2015 01:42
JeffBezanson added a commit that referenced this pull request Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants