Skip to content

Ensure the backtrace is shown even if we can't show method candidates #13904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2015
Merged

Ensure the backtrace is shown even if we can't show method candidates #13904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion base/replutil.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,11 @@ function showerror(io::IO, ex::MethodError)
print(io, "This may have arisen from a call to the constructor $construct_type(...),",
"\nsince type constructors fall back to convert methods.")
end
show_method_candidates(io, ex)
try
show_method_candidates(io, ex)
catch
warn("Unable to show method candidates")
Copy link
Contributor

@tkelman tkelman Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be warn(io, ?

Copy link
Member Author

@timholy timholy Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure; wouldn't you want it to go to STDERR?

Copy link
Contributor

@tkelman tkelman Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the output is going to io, seems odd to have part of it not. What about in IJulia, does this result in the warning going to the terminal that's running the kernel instead of the output cell?

Copy link
Member Author

@timholy timholy Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right. Especially since we're already in the middle of producing output for an error. Will fix.

end
end

#Show an error by directly calling jl_printf.
Expand Down