-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Get libgcc dlls from opensuse as part of make win-extras #10244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
probably should have written this in python instead of sh... implement rpm_select and rpm_provides implement downloading into usr/bin simplify even further by skipping requires run in dist-extras don't need rpm_provides with this version either
as part of win-extras
|
@staticfloat have you ever seen |
|
No, not quite sure what that's about. I've restarted the build, we'll see On Wed, Feb 18, 2015 at 6:42 PM, Tony Kelman [email protected]
|
|
Fluke, apparently. Feedback on this approach, or should we just give it a shot on the buildbots and see what happens? |
|
Yeah, I think we should just give it a shot |
Get libgcc dlls from opensuse as part of make win-extras
|
BTW how do we control the buildbots staying up-to-date on their cygwin packages? IIRC packer/vagrant wound up not quite working with the type of virtualization you use for them? |
|
I have an ansible script that I run every now and then to update everything On Thu, Feb 19, 2015 at 2:36 PM, Tony Kelman [email protected]
|
|
Yeah, same command that I use to initially install the cygwin packages, with the |
|
Looks like winrpm.sh works at least on the 64 bit buildbot http://buildbot.e.ip.saba.us:8010/builders/package_win8.1-x64/builds/329/steps/make%20win-extras/logs/stdio The 32 bit build hit the same issue-10045 segfault that appveyor's been hitting. We can look over the logs after running this for a few days and see whether or not the connectivity is a real problem. The opensuse build service rebuilds these rpm's automatically any time any of their dependencies change, and uploads a new revision number. I wonder whether the caching approach that we're using for homebrew on Travis could be made to work for these too... |
|
Yes, it absolutely can. In fact, we can cache everything from winrpm if we On Thu, Feb 19, 2015 at 3:35 PM, Tony Kelman [email protected]
|
😭 because Windows testing is not enough Russian roulette already... |
|
Well, see the issue mentioned up top. And JuliaPackaging/WinRPM.jl#36. It would be great if the repository we were pulling binaries from was stable like a released linux distro, but it isn't, it's a continuously rebuilding development repo. We should at least do the caching thing, that'll help with the reliability if not the actual upstream binary stability. |
|
Alright, we just need to change the winrpm downloads to prepend On Thu, Feb 19, 2015 at 3:46 PM, Tony Kelman [email protected]
|
|
Cool. We'll only want to do that for the rpm files, not the repodata xml since that is expected to change regularly. |
|
Good call! On Tue, Feb 24, 2015 at 2:43 AM, Tony Kelman [email protected]
|
This is to address JuliaInterop/ZMQ.jl#69
I originally wanted to make the
win-extrastarget shorter, with an aim of getting rid of it as soon as we can expunge our dependency on command-line git for Pkg. Unfortunately putting these dll's inusr/binbreaksllvm-config.exewhen compiled with Cygwin's version of MinGW-w64. Doing it as part ofwin-extrasappears to work though, they get downloaded intodist-extrasand only copied into the installed folder duringmake dist. No more need to restart Julia for dlopen of ZMQ or Cbc dll's to work.This runs the risk of making the buildbots susceptible to opensuse connectivity flakiness, we'll have to see.