add missing methods for division of Hessenberg matrices #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. We may also add a check for the upper |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 93.73% 93.74%
=======================================
Files 34 34
Lines 15746 15762 +16
=======================================
+ Hits 14760 14776 +16
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
reviewed
Apr 30, 2025
jishnub
approved these changes
Apr 30, 2025
Co-authored-by: Jishnu Bhattacharya <[email protected]>
jishnub
added a commit
that referenced
this pull request
May 12, 2025
As noted [on discourse](https://discourse.julialang.org/t/add-a-upperhessenberg-row-in-linearalgebra-factorize/128530/4?u=stevengj), we were missing `/` and `\` methods for `UpperHessenberg` matrices, despite the existence of optimized `ldiv!` and `rdiv!` methods, so it was falling back to slow $O(n^3)$ methods. While I was at it, I also added methods for transpose/adjoint Hessenberg matrices. --------- Co-authored-by: Jishnu Bhattacharya <[email protected]> (cherry picked from commit 9d26faf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on discourse, we were missing$O(n^3)$ methods.
/and\methods forUpperHessenbergmatrices, despite the existence of optimizedldiv!andrdiv!methods, so it was falling back to slowWhile I was at it, I also added methods for transpose/adjoint Hessenberg matrices.