Skip to content

fix herk with complex α #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

fix herk with complex α #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccfdee9
fix herk with complex α
araujoms Apr 22, 2025
07450a1
Update test/matmul.jl
araujoms Apr 22, 2025
a3ed178
Update test/matmul.jl
araujoms Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ Base.@constprop :aggressive function herk_wrapper!(C::StridedMatrix{TC}, tA::Abs
end

# BLAS.herk! only updates hermitian C, alpha and beta need to be real
if iszero(β) || ishermitian(C)
if isreal(α) && isreal(β) && (iszero(β) || ishermitian(C))
alpha, beta = promote(α, β, zero(T))
if (alpha isa T && beta isa T &&
stride(A, 1) == stride(C, 1) == 1 &&
Expand Down
4 changes: 4 additions & 0 deletions test/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,10 @@ end
@test mul!(copy(C), A', A, true, 2) ≈ 3C
D = Matrix(Hermitian(A * A'))
@test mul!(copy(D), A, A', true, 3) ≈ 4D
if T <: Complex
@test mul!(2C, A', A, im, 2) ≈ (4 + im) * C
@test mul!(2D, A, A', im, 3) ≈ (6 + im) * D
end
end
end

Expand Down