Skip to content

fix dispatch to herk #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix dispatch to herk #1247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda559f
fix dispatch to herk
araujoms Mar 26, 2025
543f938
fix typo in syrk_wrapper!
araujoms Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ end
# the aggressive constprop pushes tA and tB into gemm_wrapper!, which is needed for wrap calls within it
# to be concretely inferred
Base.@constprop :aggressive function syrk_wrapper!(C::StridedMatrix{T}, tA::AbstractChar, A::StridedVecOrMat{T},
alpha::Number, beta::Number) where {T<:BlasFloat}
α::Number, β::Number) where {T<:BlasFloat}
nC = checksquare(C)
tA_uc = uppercase(tA) # potentially convert a WrapperChar to a Char
if tA_uc == 'T'
Expand All @@ -708,16 +708,16 @@ Base.@constprop :aggressive function syrk_wrapper!(C::StridedMatrix{T}, tA::Abst

# BLAS.syrk! only updates symmetric C
# alternatively, make non-zero β a show-stopper for BLAS.syrk!
if iszero(beta) || issymmetric(C)
α, β = promote(alpha, beta, zero(T))
if iszero(β) || issymmetric(C)
alpha, beta = promote(α, β, zero(T))
if (alpha isa Union{Bool,T} &&
beta isa Union{Bool,T} &&
stride(A, 1) == stride(C, 1) == 1 &&
_fullstride2(A) && _fullstride2(C))
return copytri!(BLAS.syrk!('U', tA, alpha, A, beta, C), 'U')
end
end
return gemm_wrapper!(C, tA, tAt, A, A, alpha, beta)
return gemm_wrapper!(C, tA, tAt, A, A, α, β)
end
# legacy method
syrk_wrapper!(C::StridedMatrix{T}, tA::AbstractChar, A::StridedVecOrMat{T}, _add::MulAddMul = MulAddMul()) where {T<:BlasFloat} =
Expand All @@ -743,7 +743,7 @@ Base.@constprop :aggressive function herk_wrapper!(C::Union{StridedMatrix{T}, St
# Result array does not need to be initialized as long as beta==0
# C = Matrix{T}(undef, mA, mA)

if iszero(β) || issymmetric(C)
if iszero(β) || ishermitian(C)
alpha, beta = promote(α, β, zero(T))
if (alpha isa Union{Bool,T} &&
beta isa Union{Bool,T} &&
Expand Down