Make use of mul indirection
#1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
- Coverage 91.97% 91.93% -0.05%
==========================================
Files 34 34
Lines 15400 15392 -8
==========================================
- Hits 14164 14150 -14
- Misses 1236 1242 +6 ☔ View full report in Codecov by Sentry. |
jishnub
approved these changes
Feb 27, 2025
dkarrasch
commented
Feb 27, 2025
dkarrasch
commented
Feb 27, 2025
dkarrasch
commented
Feb 28, 2025
|
I am not sure how the backporting process is handled in LinearAlgebra. Is there any chance that this indirection strategy can be backported to 1.10? Or maybe just the PR #1210? |
|
Given the potential to address a wide range of method ambiguities, it might make sense to backport this. |
jishnub
added
backport 1.11
|
Merge? The test failure seems unrelated. |
dkarrasch
added a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #1210, but doesn't need backporting, I guess.