Skip to content

Add fast path in generic matmul #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Add fast path in generic matmul #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b46941
Add fast path in generic matmul
jakobnissen Feb 12, 2025
3a5bdbe
Fixup tests
jakobnissen Feb 13, 2025
cbe2f39
Handle missing
jakobnissen Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,6 +1021,7 @@ function _generic_matmatmul_nonadjtrans!(C, A, B, alpha, beta)
@inbounds for n in axes(B, 2), k in axes(B, 1)
# Balpha = B[k,n] * alpha, but we skip the multiplication in case isone(alpha)
Balpha = @stable_muladdmul MulAddMul(alpha, false)(B[k,n])
!ismissing(Balpha) && iszero(Balpha) && continue
@simd for m in axes(A, 1)
C[m,n] = muladd(A[m,k], Balpha, C[m,n])
end
Expand Down
1 change: 1 addition & 0 deletions test/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,7 @@ import LinearAlgebra: Adjoint, Transpose
(*)(x::RootInt, y::Integer) = x.i * y
adjoint(x::RootInt) = x
transpose(x::RootInt) = x
Base.zero(::RootInt) = RootInt(0)

@test Base.promote_op(*, RootInt, RootInt) === Int

Expand Down