Skip to content

Fix doctest #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix doctest #1199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be64cf
Fix doctest
ViralBShah Feb 10, 2025
9d0a260
Merge branch 'master' into vs/cholesky-doctest
ViralBShah Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cholesky.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ julia> C.U
⋅ ⋅ 3.0

julia> C.L
3×3 LowerTriangular{Float64, Adjoint{Matrix{Float64}}}:
3×3 LowerTriangular{Float64, {Matrix{Float64}}:
Copy link
Member

@KristofferC KristofferC Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right, or? Maybe

Suggested change
3×3 LowerTriangular{Float64, {Matrix{Float64}}:
3×3 LowerTriangular{Float64, Matrix{Float64}}:

Copy link
Member

@dkarrasch dkarrasch Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a mismatch between used code and tests in the failing doctest. This has been changed deliberately lately IIRC.

Copy link
Member

@KristofferC KristofferC Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the docs don't run with the custom sysimage and are in fact testing the bundled LinearAlgebra. Could that be correct?

2.0 ⋅ ⋅
6.0 1.0 ⋅
-8.0 5.0 3.0
Expand Down