Skip to content

Conversation

@IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jan 26, 2025

Fixes failure on julia CI JuliaLang/julia#57162
also adds the same ambiguity test here.

  | 2025-01-26 11:12:11 EST | ambiguous                                        (3) \|         failed at 2025-01-26T08:12:11.695
  | 2025-01-26 11:12:11 EST | Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-94bacb2dc4/share/julia/test/ambiguous.jl:205
  | 2025-01-26 11:12:11 EST | Expression: isempty(detect_ambiguities(modules...; recursive = true, allowed_undefineds))
  | 2025-01-26 11:12:11 EST | Evaluated: isempty(Tuple{Method, Method}[(remotecall_pool(rc_f::typeof(remotecall), f, pool::AbstractWorkerPool, args...; kwargs...) @ Distributed /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-94bacb2dc4/share/julia/stdlib/v1.12/Distributed/src/workerpool.jl:140, remotecall_pool(rc_f, f, pool::CachingPool, args...; kwargs...) @ Distributed /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-94bacb2dc4/share/julia/stdlib/v1.12/Distributed/src/workerpool.jl:392), (kwcall(::NamedTuple, ::typeof(Distributed.remotecall_pool), rc_f::typeof(remotecall), f, pool::AbstractWorkerPool, args...) @ Distributed /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-94bacb2dc4/share/julia/stdlib/v1.12/Distributed/src/workerpool.jl:140, kwcall(::NamedTuple, ::typeof(Distributed.remotecall_pool), rc_f, f, pool::CachingPool, args...) @ Distributed /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-94bacb2dc4/share/julia/stdlib/v1.12/Distributed/src/workerpool.jl:392)])
  | 2025-01-26 11:12:11 EST

@codecov
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.32%. Comparing base (2c0e979) to head (85ab2a2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/workerpool.jl 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   79.26%   79.32%   +0.05%     
==========================================
  Files          10       10              
  Lines        1934     1949      +15     
==========================================
+ Hits         1533     1546      +13     
- Misses        401      403       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth IanButterworth force-pushed the ib/fix_ambiguity branch 2 times, most recently from e34106d to 17059ce Compare January 27, 2025 01:17
@IanButterworth IanButterworth changed the title Fix ambiguity in remotecall_pool specialized for remotecall Fix ambiguity in remotecall_pool specialized for remotecall. Add test. Add Aqua tests. Jan 27, 2025
@IanButterworth IanButterworth force-pushed the ib/fix_ambiguity branch 2 times, most recently from 950ec91 to 4b08188 Compare January 27, 2025 02:51
@IanButterworth
Copy link
Member Author

This just needs approval to pass merge requirements.

Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IanButterworth IanButterworth merged commit 8890288 into master Jan 27, 2025
8 checks passed
@IanButterworth IanButterworth deleted the ib/fix_ambiguity branch January 27, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants