- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 115
Add BLAS.get_num_threads #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Should  | 
| I tried to minimally adapt the PR's tests, but I agree that it's odd that  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| Compat.set_num_threads(default) | ||
|  | ||
| if VERSION < v"1.6.0-DEV.322" | ||
| # These tests from PR rely on internal functions which would be BLAS. not Compat. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit ugly but I can't think of a better way either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also dump these & call testing the overall behaviour enough, here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But IIUC, some of the code below explicitly invokes code paths not hit by usual CI, so might be worth it. Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that approval was a bit too fast:
WARNING: Compat.Sys is deprecated, use Base.Sys instead.
  likely near /home/travis/build/JuliaLang/Compat.jl/test/runtests.jl:468
Co-authored-by: Martin Holters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once CI passes (assuming it doesn't surprise me with new warnings).
Ref JuliaLang/julia#36360
Note that I didn't export this, leaving it as
Compat.get_num_threads(), but did import the version from LinearAlgebra when defined.Also, I copied the new version of
set_num_threads()here, rather than calling the existing one.