Remove non-default GenericGraph constructor #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 97.26% 97.26% -0.01%
==========================================
Files 115 115
Lines 6796 6794 -2
==========================================
- Hits 6610 6608 -2
Misses 186 186 |
gdalle
approved these changes
Sep 21, 2023
|
wanna merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
GenericGraph(elist)constructor.The reason why we do not want to have such a constructor, is that we use
GenericGraphto verify that an interface that uses anAbstractGraphonly uses the methods as defined in the informal interface.In the future, we might add convenience functions such as
generic_graph(elist)that could help us de-clutter our tests.