Switch to oneunit (and other smaller changes)
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Sep 17, 2017
|
|
||
| one{C<:AbstractRGB}(::Type{C}) = C(1,1,1) | ||
| one{C<:TransparentRGB}(::Type{C}) = C(1,1,1,1) | ||
| oneunit{C<:AbstractRGB}(::Type{C}) = C(1,1,1) |
Contributor
There was a problem hiding this comment.
If you use where, you'll avoid deprecation warnings on 0.7.
Member
Author
There was a problem hiding this comment.
I want to save some work so that femocleaner feels valued. Even bots have feelings.
ararslan
reviewed
Sep 17, 2017
src/ColorVectorSpace.jl
Outdated
| for f in (:min, :max) | ||
| @eval begin | ||
| @deprecate($f{T<:Gray}(x::Number, y::AbstractArray{T}), | ||
| @compat $f.(x, y)) |
Contributor
There was a problem hiding this comment.
Since the package no longer supports 0.4, you can drop the @compat for dot broadcast.
Gray is the only one with an order, so no other colorants make sense
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
+ Coverage 67.16% 75.87% +8.7%
=========================================
Files 2 1 -1
Lines 265 199 -66
=========================================
- Hits 178 151 -27
+ Misses 87 48 -39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base julia has distinguished
oneandoneunit, and we should do so, too. This is sure to cause quite a few deprecation warnings in dependent packages (e.g., Images).This also adds support for
middleand fixes #56 (in separate commits).