Skip to content

Conversation

@tkoolen
Copy link
Contributor

@tkoolen tkoolen commented Apr 7, 2017

In anticipation of the next release.

@c42f
Copy link
Member

c42f commented Apr 7, 2017

Hmm, on a closer look we're really close to getting away without this (at least if the static arrays changes are confined to JuliaArrays/StaticArrays.jl#134), but not quite, because the abstract StaticMatrix would include size parameters and Rotation inherits from it.

I think the range 0.4.0 0.5- might be more appropriate? @andyferris I assume if you merge the breaking changes in https://github.com/JuliaArrays/StaticArrays.jl/pull/134/files it will be StaticArrays-0.5.0?

@andyferris
Copy link
Contributor

andyferris commented Apr 7, 2017 via email

@tkoolen
Copy link
Contributor Author

tkoolen commented Apr 8, 2017

Just wait a couple more days for the next StaticArrays release?

@c42f
Copy link
Member

c42f commented Apr 8, 2017

@andyferris I'm a bit confused, I don't think v"0.4+" is very meaningful in the REQUIRE file - in semver the + is meant to separate the version from the build number. I don't think there's an intentional way to specify an open interval for the lower bound, if that's what you were going for.

@tkoolen Might be more than a few days before the next StaticArrays release.

In anticipation of the next release.

Change upper bound to 0.5-.
@tkoolen tkoolen force-pushed the staticarrays-upper-bound branch from 43bf100 to 1a71043 Compare April 11, 2017 14:01
@tkoolen
Copy link
Contributor Author

tkoolen commented Apr 11, 2017

Alright, changed upper bound to 0.5-.

@tkoolen tkoolen merged commit aeb9c30 into JuliaGeometry:master Apr 11, 2017
@tkoolen tkoolen deleted the staticarrays-upper-bound branch April 11, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants