Skip to content

Conversation

@hyrodium
Copy link
Collaborator

With #52 merged, the == method no longer checks the norm field. This PR fixes the problem in the test.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #66 (6c824bc) into master (688e167) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   55.43%   55.43%           
=======================================
  Files           3        3           
  Lines         359      359           
=======================================
  Hits          199      199           
  Misses        160      160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688e167...6c824bc. Read the comment docs.

Copy link
Collaborator

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sethaxen sethaxen merged commit 766add4 into JuliaGeometry:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants