Remove norm field and update normalization functions

[sethaxen]

This PR primarily removes the :norm field of Quaternion and updates all code and tests accordingly (fixes #60). It also:

• removes the normalize overload in favor of sign. (fixes Drop normalize for quaternions #69)
• renames normalizea to sign_abs (exported)
• removes normalizea
• removes argq
• removes normalizeq (only used internally for argq and makes no sense apart from it)

The first 2 are breaking. I wonder also if we should remove sign_abs. We don't use it internally, and something like sign_abs iss general-purpose and unrelated to quaternions.

Supersedes #75

[codecov]

Codecov Report

Merging #108 (b519d49) into main (b04badb) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   98.67%   98.44%   -0.24%     
==========================================
  Files           1        1              
  Lines         227      193      -34     
==========================================
- Hits          224      190      -34     
  Misses          3        3              

Impacted Files	Coverage Δ
src/Quaternion.jl	98.44% <100.00%> (-0.24%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hyrodium]

I wonder also if we should remove sign_abs. We don't use it internally, and something like sign_abs iss general-purpose and unrelated to quaternions.

I agree with removing sign_abs (normalizea).

[sethaxen]

For that matter, should we remove argq? It likewise is not part of the API and is nowhere used internally.

[hyrodium]

For that matter, should we remove argq? It likewise is not part of the API and is nowhere used internally.

I think the function can be removed too. I also think that the name of the function is not common and inappropriate.

[hyrodium]

Added a minor suggestion on a dosctring. I'll review other points after resolving the conflicts.

[sethaxen]

@hyrodium this should be ready for final review.

[hyrodium]

Thank you for the updates! LTGM:+1: