This repository was archived by the owner on Nov 22, 2023. It is now read-only.
[wip] drop 0.4 + fixes for 0.6 #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will try to fix the remaining errors on the branch #80 |
SimonDanisch
added a commit
that referenced
this pull request
Apr 6, 2017
|
#80 seems to be passing with your changes, so I'll close this for now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimonDanisch tests are passing on 0.5, but not on 0.6, probably because FixedSizeArrays has not been updated yet.
A minor problem
slicehas been removed from base in favour of view. Do you want to keep that name?A major one
is not allowed anymore, you cannot inherit from a union. For the time being I removed the inheritance. An option would be to add another layer of (unparametrized) abstraction above GeometryPrimitive. You can carry on from here if you want or give me some direction.
Cheers,
Carlo