Improve tests and minor fixes

[Sov-trotter]

No description provided.

[codecov-commenter]

Codecov Report

Merging #44 into master will increase coverage by 2.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   62.01%   64.25%   +2.24%     
==========================================
  Files          13       13              
  Lines         803      803              
==========================================
+ Hits          498      516      +18     
+ Misses        305      287      -18     

Impacted Files	Coverage Δ
src/offsetintegers.jl	90.00% <ø> (+55.00%)	⬆️
src/rectangles.jl	49.21% <0.00%> (+0.52%)	⬆️
src/metadata.jl	68.75% <0.00%> (+12.50%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b299022...af1d4fd. Read the comment docs.

[Sov-trotter]

Fixes #45

[goretkin]

The GeometryBasics qualification on value really should not be needed. I just cloned the branch Sov-trotter:tests_improv, removed the qualification, and all the tests (including the new ones written, woohoo) pass.

xref: https://github.com/JuliaGeometry/GeometryTypes.jl/pull/187/files

Can you see if you're still getting the issue in #45 after removing the qualification? If you are, then please provide a reproducing example.

This does not produce the error:

import GeometryBaics: OffsetInteger
OffsetInteger{0}(1) + OffsetInteger{0}(1)

[Sov-trotter]

I guess I was running it in REPL so the error ?
BTW, the tests do pass after removing the qualification! Thanks!

[SimonDanisch]

Thanks!