Skip to content

Bump minimum Julia to 1.2 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2020
Merged

Bump minimum Julia to 1.2 #32

merged 4 commits into from
May 19, 2020

Conversation

sjkelly
Copy link
Member

@sjkelly sjkelly commented May 6, 2020

hasproperty is required and only 1.2+

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #32 into master will increase coverage by 1.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   55.00%   56.47%   +1.46%     
==========================================
  Files          13       13              
  Lines         789      834      +45     
==========================================
+ Hits          434      471      +37     
- Misses        355      363       +8     
Impacted Files Coverage Δ
src/metadata.jl 54.00% <0.00%> (-4.14%) ⬇️
src/viewtypes.jl 69.44% <0.00%> (+2.77%) ⬆️
src/basic_types.jl 68.46% <0.00%> (+10.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62371e8...50ecba9. Read the comment docs.

@SimonDanisch SimonDanisch merged commit 865a3d5 into master May 19, 2020
@SimonDanisch SimonDanisch deleted the sjk/compat12 branch May 19, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants