Skip to content

Prototype docs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 13, 2020
Merged

Conversation

asinghvi17
Copy link
Contributor

@asinghvi17 asinghvi17 commented Mar 24, 2020

Builds on the sd/finish branch. Adds a couple of documentation pages with not much on there yet.

cc: @Tokazama

@Tokazama
Copy link
Contributor

Should I start transferring relevant docs from GeometryTypes here or is this just going to be a good placeholder for documentation for the time being?

@asinghvi17
Copy link
Contributor Author

I think transferring the documentation here would be worthwhile, I'll make you a collaborator in my fork. It should probably be reworked, though!

@Tokazama
Copy link
Contributor

Why do we have contains if it is exactly equivalent to in?

@asinghvi17
Copy link
Contributor Author

I would guess it's meant to avoid piracy, but am not sure.

@asinghvi17 asinghvi17 changed the base branch from sd/finish to master April 13, 2020 06:07
@asinghvi17
Copy link
Contributor Author

@SimonDanisch should this be merged?

@SimonDanisch
Copy link
Member

Yes thank you :)

@SimonDanisch SimonDanisch merged commit 3d264d0 into JuliaGeometry:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants