Skip to content

Added ColVecs #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2020
Merged

Added ColVecs #84

merged 7 commits into from
Apr 17, 2020

Conversation

@theogf
Copy link
Member

@theogf theogf commented Apr 17, 2020

As a prerequisite of #83, this is the implementation of ColVecs taken from Stheno.jl

@theogf theogf mentioned this pull request Apr 17, 2020
Merged
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
theogf and others added 2 commits April 17, 2020 12:01
@theogf theogf requested a review from willtebbutt April 17, 2020 10:02
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
@willtebbutt
Copy link
Member

willtebbutt commented Apr 17, 2020

Thanks for sorting this @theogf .

I implemented ColVecs quite a while ago now. If I'm honest I would consider removing most of the methods implemented, including zero,view, iterate. Basically everything that isn't necessary for show / display / generally printing the object. As @devmotion points out, it might be possible to go down to a single method of getindex as well, which would be great.

@devmotion
Copy link
Member

devmotion commented Apr 17, 2020

It's also quite inconsistent that indexing yields arrays whereas iteration yields views. I guess that should be changed - maybe always return views? Then iterate could be removed.

@theogf
Copy link
Member Author

theogf commented Apr 17, 2020

Yeah I am removing everything necessary and rely on view only

devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
@theogf
Copy link
Member Author

theogf commented Apr 17, 2020

I think this should be ready to merge.
I did not implement view as I don't think we will need it anyway...

devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
devmotion
devmotion reviewed Apr 17, 2020
View reviewed changes
willtebbutt
willtebbutt approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Next to refactor out obsdim!

@theogf theogf merged commit c09ec42 into JuliaGaussianProcesses:master Apr 17, 2020
@theogf theogf deleted the colvecs branch November 24, 2020 16:33
@devmotion devmotion mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmotion devmotion devmotion left review comments

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theogf @willtebbutt @devmotion