Relax allocation test #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 52 52
Lines 1458 1458
=======================================
Hits 1325 1325
Misses 133 133 ☔ View full report in Codecov by Sentry. |
simsurace
force-pushed
the
test-transform-1.8
branch
from
4f68dca to
84caa3d
Compare
simsurace
changed the title
This reverts commit 84caa3d.
devmotion
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #526. For some reason I have not been able to figure out, starting from Julia 1.9 the allocations in these AD calls can be off by one from call to call. This PR relaxes the test slightly. I think this still serves the original purpose of the test.