Avoid failures when cleaning docs #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
reviewed
Mar 22, 2021
Comment on lines
23
to
24
| env: | ||
| PRNUM: ${{ github.event.number }} |
Member
There was a problem hiding this comment.
I don't think you want to delete that 😄
theogf
reviewed
Mar 22, 2021
| - name: Delete preview and history + push changes | ||
| run: | | ||
| git push --force origin gh-pages-new:gh-pages | ||
| if [ -d "previews/PR$PRNUM" ]; then |
Member
There was a problem hiding this comment.
Also where does the [ -d ] syntax comes from? I could not find anything in the docs...
Member
Author
There was a problem hiding this comment.
This is just bash syntax. It checks if the folder actually exists.
theogf
approved these changes
Mar 22, 2021
Member
Author
|
Let's see if it works as expected the next time someone opens a PR from a forked repository. |
Member
Author
|
At least it worked for this PR, so we didn't break the existing setup 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make the cleanup action a bit safer. Currently it fails if the preview does not exist, e.g., if a PR is opened from a fork (e.g., #261).