Remove BaseKernel and deprecated functions #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Aug 4, 2020
Member
willtebbutt
left a comment
willtebbutt
left a comment
There was a problem hiding this comment.
LGTM. I think we can safely call this non-breaking, so patch bump is all that's required.
Member
Author
|
@willtebbutt Given that we remove the deprecated functions shouldn't this be a breaking release actually? |
Member
Author
|
At least after #147 is merged we should make a breaking release. A lot of major bugs have been fixed! |
Member
If they're just bug fixes then we shouldn't make a breaking release -- we should only do that if there are breaking changes. |
Member
|
I think you're right about the deprecated functions though -- a minor release is probably in order. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #149, this removes BaseKernel as well as the transition for deprecated constructors