Skip to content

re-order checks #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

matbesancon
Copy link
Contributor

I still have to run some benchmarks there, but the function required a bit of cleanup

@matbesancon
Copy link
Contributor Author

Old version:

julia> @time matrix2graph2(jacsparsity, false)
671.048112 seconds (4.25 M allocations: 154.679 MiB, 0.02% gc time)

julia> @time matrix2graph2(jacsparsity, false)
663.122243 seconds (4.23 M allocations: 153.784 MiB, 0.01% gc time)

New version:

julia> @time matrix2graph(jacsparsity, false)
633.793763 seconds (1.02 M allocations: 100.897 MiB, 0.01% gc time)

julia> @time matrix2graph(jacsparsity, false)
606.861388 seconds (719.88 k allocations: 85.712 MiB, 0.02% gc time)

@ChrisRackauckas ChrisRackauckas merged commit a28851e into JuliaDiff:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants