Skip to content

VecJac also has inplace definitions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023
Merged

VecJac also has inplace definitions #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SparseDiffTools"
uuid = "47a9eef4-7e08-11e9-0b38-333d64bd3804"
authors = ["Pankaj Mishra <[email protected]>", "Chris Rackauckas <[email protected]>"]
version = "2.5.0"
version = "2.5.1"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
4 changes: 3 additions & 1 deletion src/differentiation/vecjac_products.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ function VecJac(f, u::AbstractArray, p = nothing, t = nothing;
throw(ArgumentError(msg))
end

return FunctionOperator(L, u, u; isinplace = IIP, outofplace = OOP,
# NOTE: The operator returned has both in-place and out-of-place definitions and
# doesn't follow the convention of `f`
return FunctionOperator(L, u, u; isinplace = true, outofplace = OOP,
p, t, islinear = true, accepted_kwargs = (:VJP_input,), kwargs...)
end

Expand Down