Skip to content

Add downstream tests to ODE.jl, clean existing tests #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2023

Conversation

vpuri3
Copy link
Contributor

@vpuri3 vpuri3 commented May 30, 2023

No description provided.

@@ -20,8 +20,6 @@ if GROUP == "Core" || GROUP == "All"
@time @safetestset "Hessian colorvecs" begin include("test_sparse_hessian.jl") end
@time @safetestset "Integration test" begin include("test_integration.jl") end
@time @safetestset "Special matrices" begin include("test_specialmatrices.jl") end
@time @safetestset "Jac Vecs and Hes Vecs" begin include("test_jaches_products.jl") end
@time @safetestset "Vec Jac Products" begin include("test_vecjac_products.jl") end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests were copied to InterfaceI but never removed from All.

if GROUP == "InterfaceI" || GROUP == "All"
@time @safetestset "Jac Vecs and Hes Vecs" begin include("test_jaches_products.jl") end
@time @safetestset "Vec Jac Products" begin include("test_vecjac_products.jl") end
end

@vpuri3 vpuri3 changed the title Add tests Add downstream tests to ODE.jl, clean existing tests May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (e4b7122) 84.95% compared to head (65dbe8d) 85.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   84.95%   85.16%   +0.20%     
==========================================
  Files          14       14              
  Lines         964      964              
==========================================
+ Hits          819      821       +2     
+ Misses        145      143       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vpuri3 vpuri3 mentioned this pull request May 31, 2023
@ChrisRackauckas ChrisRackauckas merged commit f3fd6ec into JuliaDiff:master May 31, 2023
@vpuri3 vpuri3 deleted the test branch May 31, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants