multivalue autodiff #221
Merged
multivalue autodiff #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
=========================================
- Coverage 0.31% 0.31% -0.01%
=========================================
Files 14 14
Lines 940 944 +4
=========================================
Hits 3 3
- Misses 937 941 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@ChrisRackauckas good to go |
ext/SparseDiffToolsZygote.jl
Outdated
| @@ -115,8 +116,8 @@ function SparseDiffTools.auto_vecjac(f, x, v) | |||
| return vec(back(reshape(v, size(vv)))[1]) | |||
| end | |||
|
|
|||
| function SparseDiffTools.ZygoteVecJac(args...; autodiff = true, kwargs...) | |||
| VecJac(args...; autodiff = autodiff, kwargs...) | |||
| function SparseDiffTools.ZygoteVecJac(args...; kwargs...) | |||
There was a problem hiding this comment.
this should just be renamed to VecJac, and AutoZygote is the Zygote version of it (but then we want to make Enzyme etc. versions soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #215