-
Notifications
You must be signed in to change notification settings - Fork 45
Zygote ext #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zygote ext #218
Conversation
running CI with dummy change since tests were failing locally. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=========================================
+ Coverage 0.21% 0.31% +0.10%
=========================================
Files 15 14 -1
Lines 936 940 +4
=========================================
+ Hits 2 3 +1
- Misses 934 937 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@ChrisRackauckas looks like SparseDiffTools needs more comprehensive testing. I am getting arrayinerface errors with 1.9 on my personal machine that are not captured on CI. |
Co-authored-by: Christopher Rackauckas <[email protected]>
Co-authored-by: Christopher Rackauckas <[email protected]>
Co-authored-by: Christopher Rackauckas <[email protected]>
Looks like package extension don't honor export statements. Rather, it is just julia> versioninfo()
Julia Version 1.9.0-rc1
Commit 3b2e0d8fbc1 (2023-03-07 07:51 UTC)
(a) pkg> st
Status `~/.julia/dev/SparseDiffTools/a/Project.toml`
[47a9eef4] SparseDiffTools v2.0.0 `..`
[e88e6eb3] Zygote v0.6.56
julia> using SparseDiffTools, Zygote
[ Info: Precompiling SparseDiffToolsZygote [25f82377-10ae-5fb8-bc0d-27fd31de4285]
julia> m = Base.get_extension(SparseDiffTools, :SparseDiffToolsZygote)
SparseDiffToolsZygote
julia> m.ZygoteVecJac
ZygoteVecJac (generic function with 1 method)
julia> ZygoteVecJac
ERROR: UndefVarError: `ZygoteVecJac` not defined
julia> SparseDiffTools.ZygoteVecJac
ERROR: UndefVarError: `ZygoteVecJac` not defined
Stacktrace:
[1] getproperty(x::Module, f::Symbol) So I think we should define and export these symbols in the main package, and write method definitions in the extension. |
@ChrisRackauckas can you merge #220 so we can test for 1x9 here? |
rerunning CI |
@ChrisRackauckas good to go |
part of #215
ref https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)