remove deprecated SparsityDetection #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.40% // Head: 81.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 15 15
Lines 898 898
=======================================
Hits 731 731
Misses 167 167 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Comment on lines
1
to
8
| function jacobian_sparsity(func::Function, output::AbstractVector{T}, input::AbstractVector{T}; kwargs...) where {T<:Number} | ||
| Symbolics.jacobian_sparsity(func,output,input) | ||
| end | ||
| function hessian_sparsity(func::Function, input::AbstractVector{T}; kwargs...) where {T<:Number} | ||
| vars = map(Symbolics.variable, eachindex(input)) | ||
| expr = func(vars; kwargs...) | ||
| Symbolics.hessian_sparsity(expr, vars) | ||
| end |
There was a problem hiding this comment.
These should go to Symbolics.jl. It's type piracy here.
|
Add the extra helper functions to Symbolics.jl, with some docs. It should really only be tested here. |
|
Released, so try removing now |
ChrisRackauckas
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reliance on deprecated
SparsityDetection.jlpackage.A decision has to be made if we want to directly support sparsity detection here, through a small wrapper around the newer functionality in
Symbolics.jl.