Skip to content

Fix allocation in auto_jacvec! #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Fix allocation in auto_jacvec! #176

merged 2 commits into from
Jan 8, 2022

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Jan 8, 2022

Before:

julia> @btime auto_jacvec!($dy, $f, $x, $v, $cache1, $cache2);
  99.454 μs (1200 allocations: 32.81 KiB)

After:

julia> @btime auto_jacvec!($dy, $f, $x, $v, $cache1, $cache2);
  44.668 μs (0 allocations: 0 bytes)

Pointed out by @chriselrod

YingboMa and others added 2 commits January 8, 2022 17:18
Before:
```julia
julia> @Btime auto_jacvec!($dy, $f, $x, $v, $cache1, $cache2);
  99.454 μs (1200 allocations: 32.81 KiB)
```

After:
```julia
julia> @Btime auto_jacvec!($dy, $f, $x, $v, $cache1, $cache2);
  44.668 μs (0 allocations: 0 bytes)
```

Co-authored-by: Chris Elrod <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #176 (b61db54) into master (66a0303) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          14       14           
  Lines         757      757           
=======================================
  Hits          596      596           
  Misses        161      161           
Impacted Files Coverage Δ
src/differentiation/jaches_products.jl 96.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a0303...b61db54. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit a37be93 into master Jan 8, 2022
@ChrisRackauckas ChrisRackauckas deleted the myb/alloc branch January 8, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants