Skip to content

Allow users to set the tag for the configs #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Allow users to set the tag for the configs #170

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93a8287
Allow users to set the tag for the configs
ChrisRackauckas Dec 12, 2021
7879092
always fully make the dual
ChrisRackauckas Dec 12, 2021
f9fd755
fix tag construction
ChrisRackauckas Dec 14, 2021
aa9fc34
fix for GPU?
ChrisRackauckas Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/differentiation/compute_jacobian_ad.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,14 @@ end
getsize(::Val{N}) where N = N
getsize(N::Integer) = N
void_setindex!(args...) = (setindex!(args...); return)
gettag(::Type{ForwardDiff.Dual{T}}) where {T} = T

const default_chunk_size = ForwardDiff.pickchunksize
const SMALLTAG = ForwardDiff.Tag(missing,Float64)

function ForwardColorJacCache(f::F,x,_chunksize = nothing;
dx = nothing,
tag = nothing,
colorvec=1:length(x),
sparsity::Union{AbstractArray,Nothing}=nothing) where {F}

Expand All @@ -25,15 +28,21 @@ function ForwardColorJacCache(f::F,x,_chunksize = nothing;
chunksize = _chunksize
end

if tag === nothing
T = typeof(ForwardDiff.Tag(f,eltype(vec(x))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set it to a custom tag here?
DiffEq is already using a few custom tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for upstream packages to set package-specific tags.

else
T = tag
end

if x isa Array
p = generate_chunked_partials(x,colorvec,chunksize)
t = similar(x,Dual{typeof(ForwardDiff.Tag(f,eltype(vec(x)))),eltype(x),length(first(first(p)))})
t = similar(x,Dual{T})
for i in eachindex(t)
t[i] = Dual{typeof(ForwardDiff.Tag(f,eltype(vec(x)))),eltype(x),length(first(first(p)))}(x[i],ForwardDiff.Partials(first(p)[i]))
t[i] = Dual{T,eltype(x),length(first(first(p)))}(x[i],ForwardDiff.Partials(first(p)[i]))
end
else
p = adapt.(parameterless_type(x),generate_chunked_partials(x,colorvec,chunksize))
_t = Dual{typeof(ForwardDiff.Tag(f,eltype(vec(x))))}.(vec(x),first(p))
_t = Dual{T,eltype(x),getsize(chunksize)}.(vec(x),ForwardDiff.Partials.(first(p)))
t = ArrayInterface.restructure(x,_t)
end

Expand All @@ -44,7 +53,7 @@ function ForwardColorJacCache(f::F,x,_chunksize = nothing;
else
tup = ArrayInterface.allowed_getindex(ArrayInterface.allowed_getindex(p,1),1) .* false
_pi = adapt(parameterless_type(dx),[tup for i in 1:length(dx)])
fx = reshape(Dual{typeof(ForwardDiff.Tag(f,eltype(vec(x))))}.(vec(dx),_pi),size(dx)...)
fx = reshape(Dual{T,eltype(dx),length(tup)}.(vec(dx),ForwardDiff.Partials.(_pi)),size(dx)...)
_dx = dx
end

Expand Down Expand Up @@ -162,7 +171,7 @@ function forwarddiff_color_jacobian(J::AbstractMatrix{<:Number},f::F,x::Abstract

for i in eachindex(p)
partial_i = p[i]
t = reshape(Dual{typeof(ForwardDiff.Tag(f,eltype(vecx)))}.(vecx, partial_i),size(t))
t = reshape(eltype(t).(vecx, ForwardDiff.Partials.(partial_i)),size(t))
fx = f(t)
if !(sparsity isa Nothing)
for j in 1:chunksize
Expand Down Expand Up @@ -230,7 +239,7 @@ function forwarddiff_color_jacobian_immutable(f,x::AbstractArray{<:Number},jac_c

for i in eachindex(p)
partial_i = p[i]
t = reshape(Dual{typeof(ForwardDiff.Tag(f,eltype(vecx)))}.(vecx, partial_i),size(t))
t = reshape(eltype(t).(vecx, ForwardDiff.Partials.(partial_i)),size(t))
fx = f(t)
if !(sparsity isa Nothing)
for j in 1:chunksize
Expand Down Expand Up @@ -311,10 +320,10 @@ function forwarddiff_color_jacobian!(J::AbstractMatrix{<:Number},

if vect isa Array
@inbounds @simd ivdep for j in eachindex(vect)
vect[j] = Dual{typeof(ForwardDiff.Tag(f,eltype(vecx)))}(vecx[j], partial_i[j])
vect[j] = eltype(t)(vecx[j], ForwardDiff.Partials(partial_i[j]))
end
else
vect .= Dual{typeof(ForwardDiff.Tag(f,eltype(vecx)))}.(vecx, partial_i)
vect .= eltype(t).(vecx, ForwardDiff.Partials.(partial_i))
end

f(fx,t)
Expand Down