Skip to content

Use SciMLBase instead of DiffEqBase #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Use SciMLBase instead of DiffEqBase #161

merged 2 commits into from
Nov 1, 2021

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Nov 1, 2021

No description provided.

@@ -8,7 +18,7 @@ function num_vecjac!(
cache2 = similar(v);
compute_f0 = true,
)
if SciMLBase.numargs(f) != 2
if _numargs(f) != 2
du .= num_jacvec(f, x, v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think this one would be num_jacvec(f, du, x, v) and then there would be one on the other dispatch which allocates? We can discuss this later though, I'll just merge and tag for now since you're using it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #161 (bbf586a) into master (17ba06d) will decrease coverage by 0.98%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   80.11%   79.12%   -0.99%     
==========================================
  Files          14       14              
  Lines         724      733       +9     
==========================================
  Hits          580      580              
- Misses        144      153       +9     
Impacted Files Coverage Δ
src/SparseDiffTools.jl 100.00% <ø> (ø)
src/differentiation/vecjac_products.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ba06d...bbf586a. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 89e6f30 into JuliaDiff:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants