Skip to content

Modify auto_jacvec for compatibility with Zygote #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mateuszbaran
Copy link
Contributor

This fixes one of the problems encountered in SciML/DiffEqFlux.jl#614 : Zygote seems to have trouble differentiating through this broadcast, so I've changed it to map. Additionally a different tag is used, more similar to what ForwardDiff.jl does. Related PR: #155 .

@codecov-commenter
Copy link

Codecov Report

Merging #157 (3f9ba40) into master (b324c2c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   83.69%   83.72%   +0.02%     
==========================================
  Files          12       12              
  Lines         687      688       +1     
==========================================
+ Hits          575      576       +1     
  Misses        112      112              
Impacted Files Coverage Δ
src/differentiation/jaches_products.jl 97.81% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b324c2c...3f9ba40. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit e86b7d4 into JuliaDiff:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants