Skip to content

fix wrong partials multiplied in FMA #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

fix wrong partials multiplied in FMA #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,13 @@ end
vx, vy = value(x), value(y)
result = fma(vx, vy, value(z))
return Dual(result,
_mul_partials(partials(x), partials(y), vx, vy) + partials(z))
_mul_partials(partials(x), partials(y), vy, vx) + partials(z))
end

@inline function Base.fma(x::Dual, y::Dual, z::Real)
vx, vy = value(x), value(y)
result = fma(vx, vy, z)
return Dual(result, _mul_partials(partials(x), partials(y), vx, vy))
return Dual(result, _mul_partials(partials(x), partials(y), vy, vx))
end

@inline function Base.fma(x::Dual, y::Real, z::Dual)
Expand Down
26 changes: 13 additions & 13 deletions test/DualTest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,20 +387,20 @@ for N in (0,3), M in (0,4), T in (Int, Float32)

@test partials(NaNMath.pow(Dual(-2.0, 1.0), Dual(2.0, 0.0)), 1) == -4.0

@test fma(FDNUM, FDNUM2, FDNUM3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
test_approx_diffnums(fma(FDNUM, FDNUM2, FDNUM3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2 + PRIMAL2*PARTIALS +
PARTIALS3)
@test fma(FDNUM, FDNUM2, PRIMAL3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2 + PRIMAL2*PARTIALS)
@test fma(PRIMAL, FDNUM2, FDNUM3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2 + PARTIALS3)
@test fma(PRIMAL, FDNUM2, PRIMAL3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2)
@test fma(FDNUM, PRIMAL2, FDNUM3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL2*PARTIALS + PARTIALS3)
@test fma(FDNUM, PRIMAL2, PRIMAL3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL2*PARTIALS)
@test fma(PRIMAL, PRIMAL2, FDNUM3) == Dual(fma(PRIMAL, PRIMAL2, PRIMAL3), PARTIALS3)
PARTIALS3))
test_approx_diffnums(fma(FDNUM, FDNUM2, PRIMAL3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2 + PRIMAL2*PARTIALS))
test_approx_diffnums(fma(PRIMAL, FDNUM2, FDNUM3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2 + PARTIALS3))
test_approx_diffnums(fma(PRIMAL, FDNUM2, PRIMAL3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL*PARTIALS2))
test_approx_diffnums(fma(FDNUM, PRIMAL2, FDNUM3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL2*PARTIALS + PARTIALS3))
test_approx_diffnums(fma(FDNUM, PRIMAL2, PRIMAL3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3),
PRIMAL2*PARTIALS))
test_approx_diffnums(fma(PRIMAL, PRIMAL2, FDNUM3), Dual(fma(PRIMAL, PRIMAL2, PRIMAL3), PARTIALS3))

# Unary Functions #
#-----------------#
Expand Down