WIP: adding more rules and fixing old ones #80
Conversation
src/rulesets/Base/base.jl
Outdated
| frule(::typeof(*), x::Number, y::Number) = x * y, Rule((Δx, Δy) -> Δx * y + x * Δy) | ||
|
|
||
| rrule(::typeof(*), x, y) = x * y, (Rule(ΔΩ -> ΔΩ * y'), Rule(ΔΩ -> x' * ΔΩ)) | ||
| rrule(::typeof(*), x::Number, y::Number) = x * y, (Rule(ΔΩ -> ΔΩ * y'), Rule(ΔΩ -> x' * ΔΩ)) |
There was a problem hiding this comment.
It's important to think about the complex case here too. All other rrules don't return the complex conjugate of the derivative, so either the conjugate transposes should be changed to unconjugated transposes, or this convention needs to be changed everywhere else
Co-authored-by: YingboMa <[email protected]>
|
Needs tests? |
|
@shashi what is the status with this branch? |
|
I'll not be able to work on this till Sep 1. Will address the comments and add tests. |
|
@shashi reckon you'll be able to finish this off at some point? Would be really great to have this merged. |
|
I'ld actually really like the tests |
|
I will add tests in a separate PR. |
Can we add the tests for the functions in |
|
Sure thing. |
|
Don't merge this yet. Git history is a bit messed up. |
|
Nevermind, it seems like a GitHub glitch. https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch |
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Needs a patch version bump. And a release tagged after merge.
Would be best to add tests for new special functions too.
But if you can't do that now, it's ok to open an issue so it's not forgotten.
|
Merge when you are ready and do remember to tag a release when you do |
7 participants
Work in progress for comments!