No Differentiable Factorial #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgubic
approved these changes
Jun 28, 2021
Member
mzgubic
left a comment
mzgubic
left a comment
There was a problem hiding this comment.
I don't think we need the tests (since we test the macro in ChainRulesCore), and the CI already takes ~35min.
test/runtests.jl
Outdated
| using Base.Broadcast: broadcastable | ||
| using ChainRules | ||
| using ChainRulesCore | ||
| using ChainRulesCore: NoTangent, rrule |
Member
There was a problem hiding this comment.
Suggested change
| using ChainRulesCore: NoTangent, rrule |
These should be exported and just work because of the line above
Member
Author
There was a problem hiding this comment.
Cool - I've removed the commit that added the tests (I was half expecting to do this anyway).
Now the changeset is just the Project.toml and adding the no diff rule.
AlexRobson
force-pushed
the
ar/no_diff_factorial
branch
from
8a27b2a to
b473b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
There are no tests for non_differentiable as discussed in #252 . This does add a test here as it fits the criterion of either "add(ing) regression tests when we find issues with these rules / decide to add extra rules" but can just remove these tests if it's not wanted.