-
Notifications
You must be signed in to change notification settings - Fork 95
Improve rules for sum
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
===========================================
- Coverage 97.64% 86.03% -11.61%
===========================================
Files 18 18
Lines 1018 931 -87
===========================================
- Hits 994 801 -193
- Misses 24 130 +106
Continue to review full report at Codecov.
|
Co-authored-by: Lyndon White <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 23 23
Lines 1878 1883 +5
=======================================
+ Hits 1849 1854 +5
Misses 29 29
Continue to review full report at Codecov.
|
|
This should be good to go. Failures on nightly look unrelated. |
Co-authored-by: David Widmann <[email protected]>
| end | ||
| x̄ = InplaceableThunk( | ||
| @thunk(broadcast(last∘tuple, x, ȳ)), | ||
| x -> x .+= ȳ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminded me we to do JuliaDiff/ChainRulesCore.jl#348
but i think even once that is merged this is still better (also that will not always work if dims are different, which maybe should change JuliaDiff/ChainRulesCore.jl#349)
Minor tweaks to rules for
sum, mostly to useInplaceableThunk.