Skip to content

Conversation

@mcabbott
Copy link
Member

Minor tweaks to rules for sum, mostly to use InplaceableThunk.

@codecov-io
Copy link

codecov-io commented Dec 26, 2020

Codecov Report

Merging #336 (f3f43b4) into master (ebc99f7) will decrease coverage by 11.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #336       +/-   ##
===========================================
- Coverage   97.64%   86.03%   -11.61%     
===========================================
  Files          18       18               
  Lines        1018      931       -87     
===========================================
- Hits          994      801      -193     
- Misses         24      130      +106     
Impacted Files Coverage Δ
src/rulesets/Base/mapreduce.jl 100.00% <100.00%> (ø)
src/rulesets/Base/evalpoly.jl 0.00% <0.00%> (-97.68%) ⬇️
src/rulesets/Base/utils.jl 0.00% <0.00%> (-80.00%) ⬇️
src/ChainRules.jl 66.66% <0.00%> (-33.34%) ⬇️
src/rulesets/LinearAlgebra/symmetric.jl 75.00% <0.00%> (-25.00%) ⬇️
src/rulesets/Statistics/statistics.jl 66.66% <0.00%> (-23.34%) ⬇️
src/rulesets/LinearAlgebra/utils.jl 66.66% <0.00%> (-20.00%) ⬇️
src/rulesets/LinearAlgebra/structured.jl 92.04% <0.00%> (-6.84%) ⬇️
src/rulesets/LinearAlgebra/norm.jl 98.24% <0.00%> (-1.76%) ⬇️
src/rulesets/LinearAlgebra/factorization.jl 99.15% <0.00%> (-0.18%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc99f7...f3f43b4. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #336 (eab273b) into master (647c440) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          23       23           
  Lines        1878     1883    +5     
=======================================
+ Hits         1849     1854    +5     
  Misses         29       29           
Impacted Files Coverage Δ
src/rulesets/Base/mapreduce.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647c440...eab273b. Read the comment docs.

@mcabbott
Copy link
Member Author

mcabbott commented May 7, 2021

This should be good to go. Failures on nightly look unrelated.

end
= InplaceableThunk(
@thunk(broadcast(lasttuple, x, ȳ)),
x -> x .+=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminded me we to do JuliaDiff/ChainRulesCore.jl#348
but i think even once that is merged this is still better (also that will not always work if dims are different, which maybe should change JuliaDiff/ChainRulesCore.jl#349)

@oxinabox oxinabox merged commit 987ee45 into JuliaDiff:master May 7, 2021
@mcabbott mcabbott deleted the sum2 branch May 7, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants